Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip chore: targets default from chrome 80 to any-target #1451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wip chore: targets default from chrome 80 to any-target #1451

wants to merge 1 commit into from
+2 −4

Conversation

Jinbao1001
Copy link
Member

@Jinbao1001 Jinbao1001 commented Jul 26, 2024 •
edited by coderabbitai bot
Loading

use swc preset-env any_targets to align umi default targets(babel-preset-env options { targets: {} })

Summary by CodeRabbit

  • 新功能

    • 更新了默认配置，以便更灵活地处理浏览器目标，通过将 Chrome 的特定版本目标移除，改为使用空对象，提供更广泛的兼容性。

  • 变更

    • 修改了配置对象中 targets 属性的默认值，简化了配置设置。

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 26, 2024 •
edited
Loading

Walkthrough

此次更改主要涉及DEFAULT_CONFIG常量的targets配置，从指定的Chrome版本80调整为一个空对象。这一变化表明，应用程序在浏览器兼容性方面采取了更灵活的策略，可能不再强制要求特定的Chrome版本，这样可以实现更广泛的兼容性。

Changes

文件路径 更改摘要
crates/mako/src/config/config.rs 修改了DEFAULT_CONFIG常量中的targets字段，从{ "chrome": 80 }改为{}，影响浏览器兼容性策略。
packages/bundler-mako/index.js 修改了getMakoConfig函数的默认targets值，从包含Chrome版本80的对象改为一个空对象，简化了配置。

Poem

小兔子欢快跳跃，
新改动如春风拂面，
目标不再设限，
兼容性更广阔，
代码如花绽放，
让我们一起欢庆此刻！ 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 146af1c and 52adb4d.

Files selected for processing (2)
  • crates/mako/src/config/config.rs (1 hunks)
  • packages/bundler-mako/index.js (1 hunks)
Additional comments not posted (2)
packages/bundler-mako/index.js (1)

603-603: 更改默认目标配置。

将 targets 属性的默认值从特定的 Chrome 版本更改为空对象 {}，这将增强与更多环境的兼容性。

crates/mako/src/config/config.rs (1)

686-686: 更改默认目标配置。

将 DEFAULT_CONFIG 常量中的 targets 字段从特定的 Chrome 版本更改为空对象 {}，这将增强与更多环境的兼容性。

sorrycc
sorrycc reviewed Jul 26, 2024
View reviewed changes
crates/mako/src/config/config.rs
@@ -683,7 +683,7 @@ const DEFAULT_CONFIG: &str = r#"
"providers": {},
"publicPath": "/",
"inlineLimit": 10000,
"targets": { "chrome": 80 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是个 break change。

@stormslowly stormslowly changed the title chore: targets default from chrome 80 to any-target wip chore: targets default from chrome 80 to any-target Aug 1, 2024
@stormslowly stormslowly mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@sorrycc sorrycc sorrycc left review comments

@PeachScript PeachScript Awaiting requested review from PeachScript

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jinbao1001 @sorrycc